Chore(deps): Remove IPToCC and numpy from base requirements #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit removes the `IPToCC` package from the base requirements file. This package was used to get the country code from an IP address, but it is no longer needed and caused 15m Docker image build times
This was an indirect dependency of iptocc and got removed when iptocc was removed from the pythonic requirements.
The code changes replace the `numpy` import with the `random` module in the `speech2song.py` and `practice.py` files. This change improves performance and removes the need for the `numpy` dependency.
drikusroor
changed the title
albertas-jn
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes the
IPToCCpackage from the base requirements file. This package was used to get the country code from an IP address, but it is no longer needed and caused 15m Docker image build times due to its dependency on thepandaslibrary, which had to be rebuilt every time.Additionally, it also removes
numpyas a dependency as there were only 4 lines of code in 2 files that were using it and which were very easy to replace with the already built-in python library ofrandom. NB: you can't seenumpyremoved frombase.txtas it was a dependency ofIPToCCtoo.