Feature/back to collection #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
approved these changes
Jul 9, 2024
backend/experiment/actions/utils.py
Outdated
Comment on lines
14
to
23
| def get_current_collection_url(session: Session) -> str: | ||
| collection_slug = session.load_json_data().get(COLLECTION_KEY) | ||
| if not collection_slug: | ||
| return None | ||
|
|
||
| if session.participant.participant_id_url: | ||
| participant_id_url = session.participant.participant_id_url | ||
| redirect_url = f'/collection/{collection_slug}?participant_id_url={participant_id_url}' | ||
| return f'/collection/{collection_slug}?participant_id_url={participant_id_url}' | ||
| else: | ||
| redirect_url = f'/collection/{collection_slug}' | ||
| return f'/collection/{collection_slug}' |
There was a problem hiding this comment.
This seems like a good function for a unit test or three (no collection slug, session with participant id url, and else)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1153: use the Django session data to set the link to return to the collection. Additional advantage is that also a (purely hypothetical)
participant_idwill be conserved. The branch also does some cleanup by removing thetoontjehoger_homerules file in the backend and theToontjeHogerfrontend component, which as of now aren't used anymore. ✌️