Fix serialization error for returning participants #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1371: the bug was caused by an old session cookie, in which the active participant already had finished sessions. Going in from this branch will assume the participant hasn't played the experiments yet, and set
times_playedto 0. This means that after theforloop,serialize_phasewould still returnNone. A bit of an edge case, but it's not unrealistic to assume that it would affect participants of active experiments after release.This branch checks the minimum session count and then sets
times_playedaccordingly. It also reintroduces the previous implementation with recursion: this means that the participant can resume a later phase, instead of just the first one.