Fix requesting sections twice in Categorization experiment #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how this is going to interact with the changes @Evert-R introduced for the preloading. Perhaps the issue will already be resolved with merge of #565 . In general, it's better to remove code rather than comment it out. If we find we need it back, we can always refer to the git history. Commented out code will confuse people outside of the project (and, given time, ourselves). |
|
Solved by #565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223
@BeritJanssen and @Evert-R
This is caused by preloading of the first section in
useEffectofPlayback.js. The section is loaded again inplaySection()when the Play button is clicked. I disabled the preloading and the Categorization, BeatAlignment, Eurovision and Tunetwins experiments seem to work fine. Do you foresee any potential problems with other experiments?