Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musicgens-scale-update #612

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Musicgens-scale-update #612

merged 4 commits into from
Nov 20, 2023

Conversation

jaburgoyne
Copy link
Contributor

Revised scale-point descriptions and added new questions to the MusicGens list (as requested at the September consortium meeting).

@BeritJanssen
Copy link
Collaborator

@jaburgoyne , I went over the file and added translation tags everywhere. Okay? Or rather keep them out? One unwanted side effect might be that if somebody answered the questionnaire coming from a Dutch language browser, they'd get "Ja" , "Nee", so translations for everything that has been translated. On the other hand, I think it is good practice to make sure our texts are i18n ready.

@jaburgoyne
Copy link
Contributor Author

In this very particular case, @BeritJanssen, it is actually better not to translate. There are 'service' questions for a consortium that is VERY sensitive about exact wording and answer choices, and so I suspect that some of them would want to throw out data even for such trivial changes as Yes becoming Ja for a Dutch speaker. (In just about any other context, of course, I 100% agree that i18n is the way to go.)

@BeritJanssen
Copy link
Collaborator

@jaburgoyne , we can "enforce" experiments to always be shown in English. Would this be sufficient to ensure we're keeping consortium members happy while already integrating the capability to translate?

@jaburgoyne
Copy link
Contributor Author

Yes, absolutely, @BeritJanssen – good solution!

@BeritJanssen BeritJanssen merged commit 57d7c31 into develop Nov 20, 2023
1 check passed
@BeritJanssen BeritJanssen deleted the musicgens-scale-update branch November 20, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants