Config: Configure test workflow to run on pushes to all branches #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pull_request events
drikusroor
force-pushed
the
config/workflow-triggers
branch
from
bcfc6da to
f551784
Compare
albertas-jn
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
This looks OK.
Also, coming back to #613, I think it would be better to move all test files from scripts to tests.
I actually disagree to this. The tests are technically stored somewhere else. The scripts folder might be a good place for other scripts in the future as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the
testworkflow would only run when pushing todevelopormain, or on thepull_requesttrigger. Now, thetestworkflow will be triggered on a push to any branch as per the varying preferences in the team.