Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/player config #648

Merged
merged 45 commits into from
Jan 15, 2024
Merged

Feature/player config #648

merged 45 commits into from
Jan 15, 2024

Conversation

BeritJanssen
Copy link
Collaborator

@BeritJanssen BeritJanssen commented Dec 11, 2023 •
edited
Loading

Close #561 : instead of a loose config, set arguments to Playback, and subclass player types.

@BeritJanssen
subclass Playback for player types
f545e22
@BeritJanssen
rules: switch to subclassed playback
2752321
@BeritJanssen
toontjehoger changes: rename SpectogramPlayer, reorganize labels
5402163
@BeritJanssen
correct __init__ logic
24efd86
@BeritJanssen
enforce sections as first argument for all player types
409a278
@BeritJanssen
change internal naming of the player type
5b0bbf6
@BeritJanssen
fix test
696d59f
@BeritJanssen
reorganize argument passing frontend
86a1047
@BeritJanssen
fix checking of play_method
efd4a9e
@BeritJanssen
Merge branch 'develop' into feature/player-config
d1dc4c9
@BeritJanssen
Merge branch 'develop' into feature/player-config
d5c1cde
@BeritJanssen
fix merge bug
179de48
@BeritJanssen
remove unused code
c57de43
@BeritJanssen
use mute to determine whether audio should be played
948a4af
@BeritJanssen
Merge branch 'develop' into feature/player-config
01bd3c9
@BeritJanssen
SongSync: mute silent view
dc9a165
@BeritJanssen
Autoplay: reuse playSection
094c052
@BeritJanssen
fix problems with playhead and component cleanup
5cde0c8
@BeritJanssen
remove play_method from methods
2807c55
@BeritJanssen
update props passed to Playback children
0fd7c6b
@BeritJanssen
remove label_style argument; move show_animation argument
23b2f79
@BeritJanssen
remove unused dependencies MultiPlayer
5379ef5
@BeritJanssen
fix React warnings
aea52b6
@BeritJanssen
player labels and test in backend
2b0f2df
@BeritJanssen
bugfix: correct import of get_test_playback
acea019
@BeritJanssen BeritJanssen marked this pull request as draft December 11, 2023 11:02
@BeritJanssen BeritJanssen marked this pull request as ready for review December 11, 2023 13:04
albertas-jn
albertas-jn approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@albertas-jn albertas-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this will be well tested before merging.

albertas-jn
albertas-jn requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@albertas-jn albertas-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests fail.

@BeritJanssen BeritJanssen mentioned this pull request Dec 18, 2023
Merged
@BeritJanssen BeritJanssen mentioned this pull request Jan 9, 2024
Merged
@BeritJanssen BeritJanssen merged commit 9999fc1 into develop Jan 15, 2024
10 checks passed
@BeritJanssen BeritJanssen deleted the feature/player-config branch January 15, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertas-jn albertas-jn albertas-jn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganize player config
2 participants
@BeritJanssen @albertas-jn