Chore(deps): Migrate to React 18 #649
Conversation
drikusroor
force-pushed
the
deps/migrate-to-react-18
branch
from
b296d9a to
9bb6374
Compare
drikusroor
changed the title
drikusroor
force-pushed
the
deps/migrate-to-react-18
branch
from
b2c1ced to
e6cec50
Compare
|
Thanks for doing this! Will the app still build from this branch? I don't see the |
|
…functionality. - Update Circle.test.js to use the jest.requireActual method to import Timer. - Create a timerSpy variable to spy on the Timer.default method. - Mock the requestAnimationFrame method to simulate the async nature of the call. - Add beforeEach and afterEach hooks to clear all mocks and setup the necessary spy. - Modify the "calls onTick and onFinish callbacks when running is true" test case to pass the required props to Circle component and improve readability. - Add a new test case "does not start timer when running is false" to verify the behavior of Circle component when running is false. - Improve the calculation of style for circle animation in the "calculates style for circle animation correctly" test case. - Clean up the code by removing unnecessary commented code and imports. This commit enhances the testability and functionality of the Circle component.
…t 18 This commit removes unnecessary testing library dependencies from the frontend package.json and useResultHandler.test.js files. By removing the @testing-library/react-hooks dependency, the codebase is simplified and optimized.
…during development
…eprecated findDOMNode warning See also: reactjs/react-transition-group#893
drikusroor
force-pushed
the
deps/migrate-to-react-18
branch
from
e6cec50 to
e42d83d
Compare
Resolves #442
This PR aims to migrate React from version 17 to version 18, which is the most recent version of React. See here for what is new in React 18.
Everything seems to work fine after the migration and some additional tweaks. However, after using React's
StrictModecomponent, I found thatfindDOMNODE, which comes from thereact-transition-groupdependency, is deprecated. I've tried if updating it would do anything but alas. It's not a urgent issue I think, but perhaps we need to address it in the future.