make non essential elements optional #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good from my end! I am sure Henkjan will probably have small requests here or there on it once we see it live, but this functionality is exactly what we asked for. Thanks so much! |
davidjohnbaker1
approved these changes
Jan 17, 2024
BeritJanssen
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Though I think it's neat that this PR gives such fine-grained control over the feedback and animations, I believe for now one control for show_animations, and one for show_score_feedback will do. Thinking ahead of #724 , this one can be HIDDEN / top / bottom_right. Will keep the options in the frontend, but adjust the backend options when merging in develop. I'd like to avoid a plethora of settings which may be hard to understand for future developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables you to configure elements of matching pairs from the top if the rules file.
These are the defaults we used to until now:
show_animations = True show_total_score = True show_score_message = True show_turn_feedback = False histogram_bars = 5(set histogram bars to zero for no histogram)
resolves #605