Close and recreate audiocontext for every play #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
reviewed
Dec 21, 2023
| @@ -107,6 +107,11 @@ export const stopBuffer = () => { | |||
|
|
|||
| // play buffer by section.id | |||
| export const playBuffer = (id) => { | |||
| // temporary solution for ios17 | |||
| // https://devcodef1.com/news/1068842/fixing-ios-17-web-audio-issue | |||
| audioContext.close(); | |||
There was a problem hiding this comment.
Will this throw an error if audioContext isn't (yet) defined, or is that impossible to happen? It is is possible to happen, perhaps we can play it defensively, e.g.:
if (audioContext) {
audioContext.close();
audioContext = new (window.AudioContext || window.webkitAudioContext)();
}
// and continue
|
It turns out that the problem with no audio persists on some iOS versions even when recreating the audioContext every time, so I think we shouldn't merge this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes and recreates the audiocontext of webaudio after each played sound.
https://devcodef1.com/news/1068842/fixing-ios-17-web-audio-issue
Hopefully this resolves issue #628
#628
If not, this PR can be discarded, for efficiency reasons.
(I cannot test this myself on IOS17)