Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that assigning questions through the admin would work for all experiments now, but it turns out it only works for those which use the
experiment.rules.base.get_questionnaire
function. Most Hooked experiments get a single question after each round, and use theexperiment.rules.base.get_single_question
function instead. Since we don't want to fully randomize the questions here, but first get demographic, then musicgens questions, I reasoned it would be faster for now to hard-code the questions "old style", and add an issue for theget_single_question
function ( #679 ), as we still need to figure a way to do "randomization in blocks" through the admin interface also.The branch also adds a test for the playhead shift in song_sync rounds, checking that indeed, the playhead advances by
silence_time
if the track should continue where it left off, and otherwisesilcence_time
+ a random jitter between min and max values.