Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/teletunes questions #678

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

BeritJanssen
Copy link
Collaborator

@BeritJanssen BeritJanssen commented Dec 20, 2023

I thought that assigning questions through the admin would work for all experiments now, but it turns out it only works for those which use the experiment.rules.base.get_questionnaire function. Most Hooked experiments get a single question after each round, and use the experiment.rules.base.get_single_question function instead. Since we don't want to fully randomize the questions here, but first get demographic, then musicgens questions, I reasoned it would be faster for now to hard-code the questions "old style", and add an issue for the get_single_question function ( #679 ), as we still need to figure a way to do "randomization in blocks" through the admin interface also.

The branch also adds a test for the playhead shift in song_sync rounds, checking that indeed, the playhead advances by silence_time if the track should continue where it left off, and otherwise silcence_time + a random jitter between min and max values.

Copy link
Contributor

@drikusroor drikusroor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, let's hard-code for now and fix #679 later. This one is supposed to go live soon right?

@BeritJanssen BeritJanssen merged commit 0cb7648 into develop Dec 21, 2023
10 checks passed
@BeritJanssen BeritJanssen deleted the feature/teletunes-questions branch December 21, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants