Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Add FloatingActionButton and UserFeedback components #692

Merged
merged 19 commits into from
Jan 8, 2024

Conversation

drikusroor
Copy link
Contributor

@drikusroor drikusroor commented Dec 28, 2023

This pull request adds the FloatingActionButton and UserFeedback components to the project. It also includes various style updates and unit tests.

At the experiment's feedback_info you can supply a parameter to turn it on or off for a given experiment by setting show_float_button to True.

For example:

def feedback_info(self):
        info = super().feedback_info()
        info['show_float_button'] = True
        return info

It currently looks like this:

Screen.Recording.2023-12-28.at.13.57.12.mov

Flow

  • User sees floating feedback button in the center right on it and clicks it
  • Floating Action Button opens with an animation
  • User enters feedback in text input
  • User clicks submit
  • If successful, a "Thank you..." message is shown
  • User can close the Floating Action Button again by clicking the "X" close icon button, or by clicking somewhere else in the screen

Questions for the reviewer(s)

  • Should we enable or disable it by default for all experiments?
  • Should it look exactly like the existing feedback button on the UvA site in the issue?
  • If not, is there anything else you would like to change to the appearance or the behavior of the components?

Resolves #264

@drikusroor drikusroor self-assigned this Dec 28, 2023
Copy link
Collaborator

@hhoning hhoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

Copy link
Collaborator

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't think it will hurt to merge this, but please remove the floating button from gold_msi for now. We should discuss with the researchers which experiments should or should not have the feedback button visible first.

@drikusroor drikusroor force-pushed the feat/add-feedback-button branch from bc4b8fe to 61efb62 Compare January 8, 2024 13:20
@drikusroor drikusroor force-pushed the feat/add-feedback-button branch from ec0a7c8 to 3152658 Compare January 8, 2024 13:52
@drikusroor drikusroor merged commit 0292787 into develop Jan 8, 2024
10 checks passed
@drikusroor drikusroor deleted the feat/add-feedback-button branch January 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feedback button
3 participants