-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Add FloatingActionButton and UserFeedback components #692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I don't think it will hurt to merge this, but please remove the floating button from gold_msi for now. We should discuss with the researchers which experiments should or should not have the feedback button visible first.
bc4b8fe
to
61efb62
Compare
ec0a7c8
to
3152658
Compare
This pull request adds the FloatingActionButton and UserFeedback components to the project. It also includes various style updates and unit tests.
At the experiment's
feedback_info
you can supply a parameter to turn it on or off for a given experiment by settingshow_float_button
toTrue
.For example:
It currently looks like this:
Screen.Recording.2023-12-28.at.13.57.12.mov
Flow
Questions for the reviewer(s)
Resolves #264