fix: refer to session.id from finalizeSession #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikusroor
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM. With regards to your comment about typescript. I can put some energy again in the Vite migration PR, which would allow us to slowly migrate to typescript. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that there was still a call to
session.currentin theAPI.finalizeSessionfunction. Not caught by a test, unfortunately. What would be a good way to catch these kind of problems? TheFinalcomponent calls this function, but mocks it. Obviously, TypeScript would warn if the function is called with the wrong types of arguments, so perhaps we can indeed introduce it gradually.