-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-helmet-async package and configure head/og tags #993
Conversation
5c73aab
to
f971f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss when it would be good to merge this. It's a nice feature to have, but I wonder how we'll deal with the fact that with #928, we'll reorganize information. For running something like Toontjehoger, it would be good that every Experiment (will be "Rule") has their own image, but if we move towards embedding every rule in an ExperimentCollection (will be "Experiment"), we'll need to refactor where the og information comes from. Or we hold this PR until after #928, but that's quite a long hold-up.
Will any of the relevant fields on an Experiment(Rule) be removed in the architectural changes? If not, I think we can keep it for now. Then we at least have the foundational code in the frontend already, which makes it easier to add OG information from other levels later on. We could also think about fallback information in case information at the current level is not available. For example:
Or maybe I understood incorrectly... Do you mean that ideally we'll put the OG information only on the Collection(Experiment) level later on? |
I think that og information should come from the |
ceac868
to
5cb1240
Compare
…le, description, image, and URL
…o Experiment component test
f895020
to
b4fd0e1
Compare
This PR adds title, description, meta and structured data information dynamically through
react-helmet
for experiments.Whenever you leave an experiment page and go to another page, like an experiment collection page, all tags reset to their original state which is based on the old implementation of using environment variables.
Resolves #834