Address Double Satisfaction Vulnerability of Multi UTxO Indexers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enhanced the one-to-many variants so that their `collective_output_validator`s are also provided with the output counts.
solidsnakedev
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @solidsnakedev for spotting this error, this PR adds extra validations to make sure the same number of script inputs are being spent as there are input indices provided in the redeemer.
Additionally, the one-to-many variants'
collective_output_validatorfunctions are now provided with the total count of outputs (aside from the list of outputs). This has little extra cost, while if users required this value, it'd cost them one additional traversal to attain.