Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python <3.8 support? #612

Closed
palfrey opened this issue Feb 18, 2024 · 4 comments · Fixed by #614
Closed

Python <3.8 support? #612

palfrey opened this issue Feb 18, 2024 · 4 comments · Fixed by #614
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@palfrey
Copy link
Contributor

palfrey commented Feb 18, 2024

I'm poking at things trying to add typing support and hitting the issue that some of the supporting packages don't have a Python 3.6 version with types. e.g. tldextract only has types from 3.2.0, and that has a minimum Python support of 3.7

Given also that https://devguide.python.org/versions/ notes 3.6 and 3.7 are both EoL, is it worth still supporting them here? I'll note they're not checked in the CI. Relatedly, its probably worth adding 3.10/11/12 to the CI builds.

@palfrey palfrey added the help wanted Extra attention is needed label Feb 18, 2024
@AndyTheFactory AndyTheFactory added the enhancement New feature or request label Feb 19, 2024
@AndyTheFactory
Copy link
Owner

Hi,
you are right, there is no much sense to keep the <3.8 support.
I wanted to keep it for the first couple of releases to make the transition easier for users of newspaper3k (which supported 3.6 )

I think for the next release it makes sense to drop the old version support, as you suggest

@palfrey
Copy link
Contributor Author

palfrey commented Feb 19, 2024

#614 implements this, and adds 3.10/11/12 testing.

@palfrey
Copy link
Contributor Author

palfrey commented Feb 19, 2024

614 isn't properly tested yet, as PRs don't get run through the Github actions flow. #615 fixes this.

@AndyTheFactory
Copy link
Owner

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants