Draft: custom parsing, serialization and matching in INI file nodes #2310
+578
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to rationalize a little on top of #2283 👍
For cluster files, we should have cluster names as section names, to be consistent with simulator parsing.
However, in past versions we have stored versions with either ID or upper case IDs in those section names.
Therefore we need to have a strategy to handle compatibility for those studies. When matching, we should be able to convert to ID and perform matching on ID, since they need to be unique anyway.