Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for locate command on new versions from 1.18 to 1.20 #318

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Add support for locate command on new versions from 1.18 to 1.20 #318

merged 6 commits into from
Mar 8, 2024

Conversation

gptlang
Copy link
Contributor

@gptlang gptlang commented Jan 15, 2024

Description

Replace mc_biome_java on versions greater than or equal to 1.18

Related Issue

#316

Motivation and Context

I want the locate command to work

How Has This Been Tested?

Tested on MacOS, Windows, and Linux. Pretty much everything works.

It still works on older versions since we reuse old WorldGenUtils below 1.18.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • My code follows the code style of this project.
  • Have you successfully ran tests with your changes locally?

@gptlang gptlang marked this pull request as draft January 15, 2024 13:14
@gptlang
Copy link
Contributor Author

gptlang commented Jan 15, 2024

Converted to draft. Nether and end doesn't work... I totally forgot about dimensions. Only started playing minecraft. Haven't even beat the end yet

@gptlang gptlang marked this pull request as ready for review January 15, 2024 13:37
@gptlang
Copy link
Contributor Author

gptlang commented Jan 15, 2024

Issues with dimension should be fixed.

Edit: Sorry for the force pushes. Needed to re-trigger the workflow because I fucked up my maven repository

@gptlang gptlang changed the title Fix locate command on new versions from 1.18 to 1.20 Add support for locate command on new versions from 1.18 to 1.20 Jan 15, 2024
@gptlang
Copy link
Contributor Author

gptlang commented Jan 16, 2024

Tested on MacOS and Windows VM. It works. Should be fine to merge.

@gptlang
Copy link
Contributor Author

gptlang commented Mar 8, 2024

I rebased and somehow that caused the CI to fail.

 /home/runner/work/meteor-rejects/meteor-rejects/src/main/java/anticope/rejects/modules/OreSim.java:215: error: chunk has private access in ChunkDataEvent
        doMathOnChunk(event.chunk);

OreSim.java isn't even changed. A bit confused

@RacoonDog
Copy link
Contributor

I rebased and somehow that caused the CI to fail.

 /home/runner/work/meteor-rejects/meteor-rejects/src/main/java/anticope/rejects/modules/OreSim.java:215: error: chunk has private access in ChunkDataEvent
        doMathOnChunk(event.chunk);

OreSim.java isn't even changed. A bit confused

ChunkDataEvent changed in meteor client, replace event.chunk with event.chunk()

@gptlang
Copy link
Contributor Author

gptlang commented Mar 8, 2024

How about

/home/runner/work/meteor-rejects/meteor-rejects/src/main/java/anticope/rejects/modules/OreSim.java:216: error: cannot find symbol
> Task :compileJava
        ChunkDataEvent.returnChunkDataEvent(event);
                      ^
  symbol:   method returnChunkDataEvent(ChunkDataEvent)
  location: class ChunkDataEvent

I can't find any references online

@gptlang
Copy link
Contributor Author

gptlang commented Mar 8, 2024

@RacoonDog
Copy link
Contributor

@C10udburst C10udburst merged commit 9fdb0c5 into AntiCope:master Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants