review fixes

Antonboom · Oct 3, 2024 · 044379d · 044379d
1 parent a7e1c09
commit 044379d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/analyzer/testdata/src/checkers-default/error-nil/error_nil_test.go b/analyzer/testdata/src/checkers-default/error-nil/error_nil_test.go
diff --git a/analyzer/testdata/src/checkers-default/error-nil/error_nil_test.go.golden b/analyzer/testdata/src/checkers-default/error-nil/error_nil_test.go.golden
@@ -84,6 +84,10 @@ func TestErrorNilChecker(t *testing.T) {
 		assert.Zerof(t, err.Error(), "msg with args %d %s", 42, "42")
 		assert.NotZero(t, err.Error())
 		assert.NotZerof(t, err.Error(), "msg with args %d %s", 42, "42")
+		assert.Nil(t, errs)
+		assert.Nilf(t, errs, "msg with args %d %s", 42, "42")
+		assert.NotNil(t, errs)
+		assert.NotNilf(t, errs, "msg with args %d %s", 42, "42")
 		assert.Empty(t, errs)
 		assert.Emptyf(t, errs, "msg with args %d %s", 42, "42")
 		assert.NotEmpty(t, errs)

diff --git a/internal/testgen/gen_error_nil.go b/internal/testgen/gen_error_nil.go
@@ -87,6 +87,8 @@ func (g ErrorNilTestsGenerator) TemplateData() any {
 			{Fn: "Zero", Argsf: "err.Error()"},
 			{Fn: "NotZero", Argsf: "err.Error()"},
 
+			{Fn: "Nil", Argsf: "errs"},
+			{Fn: "NotNil", Argsf: "errs"},
 			{Fn: "Empty", Argsf: "errs"},
 			{Fn: "NotEmpty", Argsf: "errs"},
 			{Fn: "Zero", Argsf: "errs"},