Update http_const.go

Antonboom · Jun 26, 2024 · 0627b54 · 0627b54
1 parent 4f71918
commit 0627b54
Showing 1 changed file with 21 additions and 20 deletions.
diff --git a/internal/checkers/http_const.go b/internal/checkers/http_const.go
@@ -39,9 +39,8 @@ func (checker HTTPConst) Check(_ *analysis.Pass, call *CallMeta) *analysis.Diagn
 		suggestedFix := newHTTPMethodReplacement(call); 
 		if suggestedFix == nil {
 			return nil
-		} else {
-			suggestedFixes = append(suggestedFixes, *suggestedFix)
 		}
+		suggestedFixes = append(suggestedFixes, *suggestedFix)
 	case "HTTPStatusCode":
 		if len(call.Args) < 5 {
 			return nil
@@ -60,29 +59,31 @@ func (checker HTTPConst) Check(_ *analysis.Pass, call *CallMeta) *analysis.Diagn
 }
 
 func newHTTPMethodReplacement(call *CallMeta) *analysis.SuggestedFix {
-	if bt, ok := safeTypedBasicLit(call.Args[1], token.STRING); ok {
-		currentVal := unquoteBasicLitValue(bt)
-		key := strings.ToUpper(currentVal)
-		newVal, ok := httpMethod[key]; 
-		if !ok {
-			return nil
-		}
-		return newConstReplacement(bt, currentVal, newVal)
+	bt, ok := safeTypedBasicLit(call.Args[1], token.STRING);
+	if !ok {
+		return nil
+	}
+	currentVal := unquoteBasicLitValue(bt)
+	key := strings.ToUpper(currentVal)
+	newVal, ok := httpMethod[key];
+	if !ok {
+		return nil
 	}
-	return nil
+	return newConstReplacement(bt, currentVal, newVal)
 }
 
 func newHTTPStatusCodeReplacement(call *CallMeta) *analysis.SuggestedFix {
-	if bt, ok := safeTypedBasicLit(call.Args[4], token.INT); ok {
-		currentVal := bt.Value
-		key := strings.ToUpper(currentVal)
-		newVal, ok := httpStatusCode[key];
-		if !ok {
-			return nil
-		}
-		return newConstReplacement(bt, currentVal, newVal)
+	bt, ok := safeTypedBasicLit(call.Args[4], token.INT);
+	if !ok {
+		return nil
+	}
+	currentVal := bt.Value
+	key := strings.ToUpper(currentVal)
+	newVal, ok := httpStatusCode[key];
+	if !ok {
+		return nil
 	}
-	return nil
+	return newConstReplacement(bt, currentVal, newVal)
 }
 
 func newConstReplacement(bt *ast.BasicLit, currentVal, newVal string) *analysis.SuggestedFix {