Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless-assert: add Zero and Empty to detected pattern #107

Closed
wants to merge 1 commit into from
Closed

useless-assert: add Zero and Empty to detected pattern #107

wants to merge 1 commit into from

Conversation

ccoVeille
Copy link
Contributor

Fixes #105

@coveralls
Copy link

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9398780801

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.793%
Totals Coverage Status
Change from base Build 9379444402: 0.0%
Covered Lines: 2025
Relevant Lines: 2159
💛 - Coveralls

@Antonboom
Copy link
Owner

I've never seen these somebody use bool operations in these assertions

does this really make sense?

@ccoVeille
Copy link
Contributor Author

ccoVeille commented Jun 6, 2024 •
edited
Loading

I would say it will catch almost nothing, but why not merging it. It costs nothing to maintain.

Your code keeps evolving and new cases might be added to useless-assert, one added later may catch code using Zero and Empty

@Antonboom Antonboom closed this Jun 8, 2024
Repository owner locked as spam and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useless-assert: add Empty And Zero
3 participants
@ccoVeille @coveralls @Antonboom