new checker http-const

CONTRIBUTING.md

@@ -138,7 +138,6 @@ Describe a new checker in [checkers section](./README.md#checkers).
 - [equal-values](#equal-values)
 - [graceful-teardown](#graceful-teardown)
 - [float-compare](#float-compare)
-- [http-const](#http-const)
 - [http-sugar](#http-sugar)
 - [require-len](#require-len)
 - [suite-test-name](#suite-test-name)
@@ -268,24 +267,6 @@ And similar idea for `assert.InEpsilonSlice` / `assert.InDeltaSlice`.
 
 ---
 
-### http-const
-
-```go
-❌   assert.HTTPStatusCode(t, handler, "GET", "/index", nil, 200)
-     assert.HTTPBodyContains(t, handler, "GET", "/index", nil, "counter")
-     // etc.
-
-✅   assert.HTTPStatusCode(t, handler, http.MethodGet, "/index", nil, http.StatusOK)
-     assert.HTTPBodyContains(t, handler, http.MethodGet, "/index", nil, "counter")
-```
-
-**Autofix**: true. <br>
-**Enabled by default**: true. <br>
-**Reason**: Is similar to the [usestdlibvars](https://golangci-lint.run/usage/linters/#usestdlibvars) linter. <br>
-**Related issues**: [#141](https://github.com/Antonboom/testifylint/issues/141)
-
----
-
 ### http-sugar
 
 ```go

README.md

@@ -101,6 +101,7 @@ https://golangci-lint.run/usage/linters/#testifylint
 | [expected-actual](#expected-actual)                 | ✅                  | ✅       |
 | [float-compare](#float-compare)                     | ✅                  | ❌       |
 | [formatter](#formatter)                             | ✅                  | 🤏      |
+| [http-const](#http-const)                           | ✅                  | ✅       |
 | [go-require](#go-require)                           | ✅                  | ❌       |
 | [len](#len)                                         | ✅                  | ✅       |
 | [negative-positive](#negative-positive)             | ✅                  | ✅       |
@@ -549,7 +550,7 @@ Typically, any assertions inside goroutines are a marker of poor test architectu
 Try to execute them in the main goroutine and distribute the data necessary for this into it
 ([example](https://github.com/ipfs/kubo/issues/2043#issuecomment-164136026)).
 
-Also a bad solution would be to simply replace all `require` in goroutines with `assert`
+Also, a bad solution would be to simply replace all `require` in goroutines with `assert`
 (like
 [here](https://github.com/gravitational/teleport/pull/22567/files#diff-9f5fd20913c5fe80c85263153fa9a0b28dbd1407e53da4ab5d09e13d2774c5dbR7377))
 – this will only mask the problem.
@@ -566,6 +567,24 @@ P.S. Look at [testify's issue](https://github.com/stretchr/testify/issues/772),
 
 ---
 
+### http-const
+
+```go
+❌
+assert.HTTPStatusCode(t, handler, "GET", "/index", nil, 200)
+assert.HTTPBodyContains(t, handler, "GET", "/index", nil, "counter")
+
+✅
+assert.HTTPStatusCode(t, handler, http.MethodGet, "/index", nil, http.StatusOK)
+assert.HTTPBodyContains(t, handler, http.MethodGet, "/index", nil, "counter")
+```
+
+**Autofix**: true. <br>
+**Enabled by default**: true. <br>
+**Reason**: Cleaner code and meaningful constants instead of magical numbers/identifiers. This checker is similar to the [usestdlibvars](https://golangci-lint.run/usage/linters/#usestdlibvars) linter. <br>
+
+---
+
 ### len
 
 ```go
@@ -880,7 +899,7 @@ a [checkers.AdvancedChecker](https://github.com/Antonboom/testifylint/blob/67632
 
 ### useless-assert
 
-Currently the checker guards against assertion of the same variable:
+Currently, the checker guards against assertion of the same variable:
 
 ```go
 ❌

analyzer/checkers_factory_test.go

@@ -27,6 +27,7 @@ func Test_newCheckers(t *testing.T) {
 		checkers.NewErrorIsAs(),
 		checkers.NewExpectedActual(),
 		checkers.NewRegexp(),
+		checkers.NewHTTPConst(),
 		checkers.NewSuiteExtraAssertCall(),
 		checkers.NewSuiteDontUsePkg(),
 		checkers.NewUselessAssert(),
@@ -45,6 +46,7 @@ func Test_newCheckers(t *testing.T) {
 		checkers.NewErrorIsAs(),
 		checkers.NewExpectedActual(),
 		checkers.NewRegexp(),
+		checkers.NewHTTPConst(),
 		checkers.NewSuiteExtraAssertCall(),
 		checkers.NewSuiteDontUsePkg(),
 		checkers.NewUselessAssert(),

analyzer/testdata/src/checkers-default/http-const/http_const_test.go.golden

@@ -0,0 +1,48 @@
+// Code generated by testifylint/internal/testgen. DO NOT EDIT.
+package httpconst
+
+import (
+	"fmt"
+	"net/http"
+	"net/url"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func httpOK(w http.ResponseWriter, r *http.Request) {
+	w.WriteHeader(http.StatusOK)
+}
+
+func httpHelloName(w http.ResponseWriter, r *http.Request) {
+	name := r.FormValue("name")
+	_, _ = fmt.Fprintf(w, "Hello, %s!", name)
+}
+
+func TestHttpConstChecker(t *testing.T) {
+	// Invalid.
+	{
+		assert.HTTPStatusCode(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK)                                                                           // want "http-const: use net/http constants instead of value"
+		assert.HTTPStatusCodef(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK, "msg with args %d %s", 42, "42")                                         // want "http-const: use net/http constants instead of value"
+		assert.HTTPStatusCode(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK)                                                                           // want "http-const: use net/http constants instead of value"
+		assert.HTTPStatusCodef(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK, "msg with args %d %s", 42, "42")                                         // want "http-const: use net/http constants instead of value"
+		assert.HTTPStatusCode(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK)                                                                           // want "http-const: use net/http constants instead of value"
+		assert.HTTPStatusCodef(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK, "msg with args %d %s", 42, "42")                                         // want "http-const: use net/http constants instead of value"
+		assert.HTTPBodyContains(t, httpHelloName, http.MethodGet, "/", url.Values{"name": []string{"World"}}, "Hello, World!")                                   // want "http-const: use net/http constants instead of value"
+		assert.HTTPBodyContainsf(t, httpHelloName, http.MethodGet, "/", url.Values{"name": []string{"World"}}, "Hello, World!", "msg with args %d %s", 42, "42") // want "http-const: use net/http constants instead of value"
+	}
+	// Valid.
+	{
+		assert.HTTPStatusCode(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK)
+		assert.HTTPStatusCodef(t, httpOK, http.MethodGet, "/index", nil, http.StatusOK, "msg with args %d %s", 42, "42")
+		assert.HTTPBodyContains(t, httpHelloName, http.MethodGet, "/", url.Values{"name": []string{"World"}}, "Hello, World!")
+		assert.HTTPBodyContainsf(t, httpHelloName, http.MethodGet, "/", url.Values{"name": []string{"World"}}, "Hello, World!", "msg with args %d %s", 42, "42")
+	}
+	// Ignored.
+	{
+		assert.HTTPStatusCode(t, httpOK, "FOO", "/index", nil, 999)
+		assert.HTTPStatusCodef(t, httpOK, "FOO", "/index", nil, 999, "msg with args %d %s", 42, "42")
+		assert.HTTPBodyContains(t, httpHelloName, "FOO", "/", url.Values{"name": []string{"World"}}, "Hello, World!")
+		assert.HTTPBodyContainsf(t, httpHelloName, "FOO", "/", url.Values{"name": []string{"World"}}, "Hello, World!", "msg with args %d %s", 42, "42")
+	}
+}

internal/checkers/checkers_registry.go

@@ -19,6 +19,7 @@ var registry = checkersRegistry{
 	{factory: asCheckerFactory(NewErrorIsAs), enabledByDefault: true},
 	{factory: asCheckerFactory(NewExpectedActual), enabledByDefault: true},
 	{factory: asCheckerFactory(NewRegexp), enabledByDefault: true},
+	{factory: asCheckerFactory(NewHTTPConst), enabledByDefault: true},
 	{factory: asCheckerFactory(NewSuiteExtraAssertCall), enabledByDefault: true},
 	{factory: asCheckerFactory(NewSuiteDontUsePkg), enabledByDefault: true},
 	{factory: asCheckerFactory(NewUselessAssert), enabledByDefault: true},

internal/checkers/checkers_registry_test.go

@@ -47,6 +47,7 @@ func TestAll(t *testing.T) {
 		"error-is-as",
 		"expected-actual",
 		"regexp",
+		"http-const",
 		"suite-extra-assert-call",
 		"suite-dont-use-pkg",
 		"useless-assert",
@@ -83,6 +84,7 @@ func TestEnabledByDefault(t *testing.T) {
 		"error-is-as",
 		"expected-actual",
 		"regexp",
+		"http-const",
 		"suite-extra-assert-call",
 		"suite-dont-use-pkg",
 		"useless-assert",

internal/checkers/helpers_basic_type.go

@@ -5,6 +5,7 @@ import (
 	"go/ast"
 	"go/token"
 	"go/types"
+	"strconv"
 
 	"golang.org/x/tools/go/analysis"
 )
@@ -56,9 +57,14 @@ func isTypedIntNumber(e ast.Expr, v int, types ...string) bool {
 	return false
 }
 
-func isIntNumber(e ast.Expr, v int) bool {
+func typeSafeBasicLit(e ast.Expr, typ token.Token) (*ast.BasicLit, bool) {
 	bl, ok := e.(*ast.BasicLit)
-	return ok && bl.Kind == token.INT && bl.Value == fmt.Sprintf("%d", v)
+	return bl, ok && bl.Kind == typ
+}
+
+func isIntNumber(e ast.Expr, v int) bool {
+	bl, ok := typeSafeBasicLit(e, token.INT)
+	return ok && bl.Value == fmt.Sprintf("%d", v)
 }
 
 func isBasicLit(e ast.Expr) bool {
@@ -67,8 +73,8 @@ func isBasicLit(e ast.Expr) bool {
 }
 
 func isIntBasicLit(e ast.Expr) bool {
-	bl, ok := e.(*ast.BasicLit)
-	return ok && bl.Kind == token.INT
+	_, ok := typeSafeBasicLit(e, token.INT)
+	return ok
 }
 
 func isUntypedConst(pass *analysis.Pass, e ast.Expr) bool {
@@ -111,3 +117,11 @@ func untype(e ast.Expr) ast.Expr {
 	}
 	return ce.Args[0]
 }
+
+func unquoteBasicLitValue(basicLit *ast.BasicLit) (string, bool) {
+	value, err := strconv.Unquote(basicLit.Value)
+	if err != nil {
+		return "", false
+	}
+	return value, true
+}

internal/checkers/helpers_diagnostic.go

@@ -68,16 +68,26 @@ func newDiagnostic(
 	msg string,
 	fix *analysis.SuggestedFix,
 ) *analysis.Diagnostic {
-	d := analysis.Diagnostic{
-		Pos:      rng.Pos(),
-		End:      rng.End(),
-		Category: checker,
-		Message:  checker + ": " + msg,
-	}
+	var suggestedFixes []analysis.SuggestedFix
 	if fix != nil {
-		d.SuggestedFixes = []analysis.SuggestedFix{*fix}
+		suggestedFixes = append(suggestedFixes, *fix)
+	}
+	return newAnalysisDiagnostic(checker, rng, msg, suggestedFixes)
+}
+
+func newAnalysisDiagnostic(
+	checker string,
+	rng analysis.Range,
+	msg string,
+	suggestedFixes []analysis.SuggestedFix,
+) *analysis.Diagnostic {
+	return &analysis.Diagnostic{
+		Pos:            rng.Pos(),
+		End:            rng.End(),
+		Category:       checker,
+		Message:        checker + ": " + msg,
+		SuggestedFixes: suggestedFixes,
 	}
-	return &d
 }
 
 func newSuggestedFuncReplacement(