Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Simpler array bounds checking #7

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

ZevEisenberg
Copy link
Contributor

@ZevEisenberg ZevEisenberg commented Mar 26, 2024

Steps

  • Add your name or username and a link to your GitHub profile into the Contributors.md file.
  • Build the project on your machine. If it does not compile, fix the errors.
  • Describe the purpose and approach of your pull request below.
  • Submit the pull request. Thank you very much for your contribution!

Purpose

This is a slightly simpler and possibly more idiomatic way to check array bounds using the array's built-in indices collection.

Approach

See above.

@ZevEisenberg ZevEisenberg marked this pull request as ready for review March 26, 2024 13:33
@ZevEisenberg
Copy link
Contributor Author

I wasn't able to build on my machine, possibly because I'm on a Mac?

Copy link
Member

@david-swift david-swift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you maybe share some information about your problem on macOS, maybe in the discussions? I tried this library on macOS the last time some months ago, and the build succeeded, so it probably isn't a general problem of the library itself, but one of the system/configuration.

@david-swift david-swift merged commit b17ec73 into AparokshaUI:main Mar 26, 2024
1 check passed
@ZevEisenberg ZevEisenberg deleted the patch-1 branch March 26, 2024 16:39
@ZevEisenberg
Copy link
Contributor Author

ZevEisenberg commented Jun 23, 2024

Apologies for the delay! Here's a screenshot of the errors I see, and some detail on the first one in the build log. I'm assuming I need some dependency installed, but the readme didn't mention anything that I could see. I installed libadwaita via homebrew, but it didn't help.

image

@david-swift
Copy link
Member

david-swift commented Jun 23, 2024

This is probably the same problem as reported in #32. Unfortunately, we haven't yet been able to fix it (but it should work with swift run instead of Xcode's run button). Maybe you could try the steps in #11 (comment), I don't know whether this helps (in general, I'd recommend installing Linux on the device or in a VM to work with Libadwaita).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants