Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with extra suffix parts in imported sources #148

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jun 10, 2024

What I did

issue where could not compile contracts that imports contracts with deeper suffixes.
for example if you are compiling Contract.sol and it was using Contract.v1.sol, it would fail because ape-solidity is only registered for .sol and not v1.sol.

This makes it work.

requires this though ApeWorX/ape#2123

also fixes a bug where flattening mistook some things in comments for import statements and hell broke loose

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review June 13, 2024 18:27
@antazoey antazoey requested a review from dtdang June 13, 2024 18:27
@antazoey antazoey changed the title fix: issue with extra suffix parts fix: issue with extra suffix parts in imported sources Jun 13, 2024
@antazoey antazoey force-pushed the fix/imports-allow-full-ext branch from 465d6f7 to 6968a15 Compare June 13, 2024 18:47
dtdang
dtdang previously approved these changes Jun 13, 2024
@antazoey
Copy link
Member Author

As always, only getting this error in CI/CD and not locally.

@dtdang
Copy link
Contributor

dtdang commented Jun 13, 2024

As always, only getting this error in CI/CD and not locally.

Ran this locally and also got the same error on the same test on my end.

@antazoey
Copy link
Member Author

OK turns out it was a real bug with flattening.
Should be good now, ill make sure it is also mentioned in the release notes.

@antazoey antazoey enabled auto-merge (squash) June 13, 2024 21:21
@antazoey antazoey merged commit a84cf38 into ApeWorX:main Jun 13, 2024
14 checks passed
@antazoey antazoey deleted the fix/imports-allow-full-ext branch July 9, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants