automan proxy contract #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2024 23:27
gaohan137
requested changes
Jul 11, 2024
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import {INonfungiblePositionManager as INPM} from "@aperture_finance/uni-v3-lib/src/interfaces/INonfungiblePositionManager.sol"; | ||
|
|
||
| interface Automan { |
There was a problem hiding this comment.
Use src/interfaces/IAutoman.sol?
There was a problem hiding this comment.
Delete interface Automan?
src/tools/AutomanProxy.sol
Outdated
| bytes32 r, | ||
| bytes32 s | ||
| ) external returns (uint256 newTokenId, uint128 liquidity, uint256 amount0, uint256 amount1) { | ||
| address owner = npm.ownerOf(tokenId); |
There was a problem hiding this comment.
Make the following logic into a modifier (similar to how we use onlyOwner):
address owner = npm.ownerOf(tokenId);
require(allowance[msg.sender][owner], "not allow relayer");
added 2 commits
July 16, 2024 11:11
gaohan137
requested changes
Jul 17, 2024
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import {INonfungiblePositionManager as INPM} from "@aperture_finance/uni-v3-lib/src/interfaces/INonfungiblePositionManager.sol"; | ||
|
|
||
| interface Automan { |
There was a problem hiding this comment.
Delete interface Automan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a proxy contract to allow whitelist only relayer