feat(eslint-config): make all config parts type-checked

ApiTreeCZ · Oct 26, 2023 · b41badf · b41badf
1 parent afc90ef
commit b41badf
Show file tree

Hide file tree

Showing 13 changed files with 49 additions and 14 deletions.
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -41,6 +41,7 @@
     "eslint-plugin-vitest": "^0.3.8"
   },
   "devDependencies": {
+    "@types/eslint": "^8.44.6",
     "eslint": "^8.52.0",
     "prettier": "^3.0.3",
     "react": "^18.2.0",

diff --git a/packages/eslint-config/src/base/config.ts b/packages/eslint-config/src/base/config.ts
@@ -1,3 +1,5 @@
+import type { Linter } from 'eslint';
+
 import { overrides } from './overrides';
 import { rules } from './rules';
 
@@ -42,4 +44,4 @@ export const config = {
     'import/resolver': { typescript: {} },
   },
   overrides,
-};
+} satisfies Linter.Config;
diff --git a/packages/eslint-config/src/base/overrides/javascript.ts b/packages/eslint-config/src/base/overrides/javascript.ts
@@ -1,4 +1,6 @@
-export const javascript = {
+import type { Linter } from 'eslint';
+
+export const javascript: Linter.ConfigOverride = {
   files: '*.js',
   rules: {
     '@typescript-eslint/no-var-requires': 'off',

diff --git a/packages/eslint-config/src/base/overrides/tests.ts b/packages/eslint-config/src/base/overrides/tests.ts
@@ -1,4 +1,6 @@
-export const tests = {
+import type { Linter } from 'eslint';
+
+export const tests: Linter.ConfigOverride = {
   files: ['*.test.ts', '*.test.tsx'],
   extends: ['plugin:vitest/recommended'],
   rules: {

diff --git a/packages/eslint-config/src/base/overrides/typescript.ts b/packages/eslint-config/src/base/overrides/typescript.ts
@@ -1,4 +1,6 @@
-export const typescript = {
+import type { Linter } from 'eslint';
+
+export const typescript: Linter.ConfigOverride = {
   files: ['*.ts', '*.tsx'],
   extends: [
     'plugin:@typescript-eslint/recommended-requiring-type-checking',

diff --git a/packages/eslint-config/src/base/rules/common.ts b/packages/eslint-config/src/base/rules/common.ts
@@ -1,4 +1,6 @@
-export const common = {
+import type { Linter } from 'eslint';
+
+export const common: Linter.RulesRecord = {
   'array-callback-return': [
     'error',
     {

diff --git a/packages/eslint-config/src/base/rules/imports.ts b/packages/eslint-config/src/base/rules/imports.ts
@@ -1,4 +1,6 @@
-export const imports = {
+import type { Linter } from 'eslint';
+
+export const imports: Linter.RulesRecord = {
   'import/extensions': [
     'error',
     'ignorePackages',

diff --git a/packages/eslint-config/src/base/rules/typescript.ts b/packages/eslint-config/src/base/rules/typescript.ts
@@ -1,4 +1,6 @@
-export const typescript = {
+import type { Linter } from 'eslint';
+
+export const typescript: Linter.RulesRecord = {
   '@typescript-eslint/no-unused-vars': 'off',
   '@typescript-eslint/no-use-before-define': 'error',
 };
diff --git a/packages/eslint-config/src/base/rules/unicorn.ts b/packages/eslint-config/src/base/rules/unicorn.ts
@@ -1,4 +1,6 @@
-export const unicorn = {
+import type { Linter } from 'eslint';
+
+export const unicorn: Linter.RulesRecord = {
   'unicorn/no-array-callback-reference': 'off',
   'unicorn/prevent-abbreviations': [
     'error',

diff --git a/packages/eslint-config/src/react/config.ts b/packages/eslint-config/src/react/config.ts
@@ -1,3 +1,5 @@
+import type { Linter } from 'eslint';
+
 import { overrides } from './overrides';
 import { rules } from './rules';
 
@@ -9,4 +11,4 @@ export const config = {
   settings: {
     react: { version: 'detect' },
   },
-};
+} satisfies Linter.Config;
diff --git a/packages/eslint-config/src/react/overrides.ts b/packages/eslint-config/src/react/overrides.ts
@@ -1,4 +1,6 @@
-export const overrides = [
+import type { Linter } from 'eslint';
+
+export const overrides: Linter.ConfigOverride[] = [
   {
     files: '*.test.tsx',
     extends: ['plugin:jest-dom/recommended', 'plugin:testing-library/react'],

diff --git a/packages/eslint-config/src/react/rules.ts b/packages/eslint-config/src/react/rules.ts
@@ -1,4 +1,6 @@
-export const rules = {
+import type { Linter } from 'eslint';
+
+export const rules: Linter.RulesRecord = {
   'react/function-component-definition': [
     'error',
     {

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml