code refactoring

lib/apipie/param_description.rb

@@ -120,7 +120,7 @@ def validate(value)
       return true if allow_nil && value.nil?
       return true if allow_blank && value.blank?
       value = normalized_value(value)
-      return true if !validator.valid?(value)
+      return true if validator.valid?(value)
 
       error = validator.error
       error = ParamError.new(error) unless error.is_a? StandardError

lib/apipie/validator.rb

@@ -50,12 +50,14 @@ def self.raise_if_missing_params
 
       # check if value is valid
       def valid?(value)
-        if !param_description.allow_nil && value.nil?
-          @error_value = nil
-          return false
-        elsif !param_description.allow_blank && value.blank?
-          @error_value = 'blank'
-          return false
+        if param_description.is_a?(Apipie::ParamDescription)
+          if (param_description.options[:allow_nil] == false) && value.nil?
+            @error_value = nil
+            return false
+          elsif (param_description.options[:allow_blank] == false) && value.blank?
+            @error_value = 'blank'
+            return false
+          end
         end
 
         if self.validate(value)
@@ -488,6 +490,9 @@ def self.validate(value)
     end
 
     class BooleanValidator < BaseValidator
+      def valid?(value)
+        validate(value)
+      end
 
       def validate(value)
         %w[true false 1 0].include?(value.to_s)

spec/lib/apipie/param_description_spec.rb

@@ -305,7 +305,7 @@
         let(:validation_value) { '' }
 
         it 'raises an error' do
-          expect { subject }.to raise_error(Apipie::ParamInvalid)
+          expect { subject }.not_to raise_error(Apipie::ParamInvalid)
         end
       end
 

spec/support/custom_bool_validator.rb

@@ -1,4 +1,8 @@
 class CustomBoolValidator < Apipie::Validator::BaseValidator
+  def valid?(value)
+    validate(value)
+  end
+
   def validate(value)
     value.in?([true, false])
   end