Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure Layout/MultilineMethodCallIndentation to ensure short indent #930

Merged
merged 6 commits into from
Jul 10, 2024
Merged

configure Layout/MultilineMethodCallIndentation to ensure short indent #930

merged 6 commits into from
Jul 10, 2024

Conversation

mathieujobin
Copy link
Collaborator

Alternative to #912

Opinion ?

ekohl
ekohl reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like more of the code is using the default style, so I'd lean to choosing that, but I don't have a strong opinion on what's better.

@mathieujobin mathieujobin reopened this Jul 9, 2024
mathieujobin
mathieujobin commented Jul 9, 2024
View reviewed changes
Copy link
Collaborator Author

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 fixed occurences, about the same in terms count

@mathieujobin mathieujobin merged commit 4be3741 into master Jul 10, 2024
50 checks passed
@mathieujobin mathieujobin deleted the short-indent branch July 10, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieujobin @ekohl