Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOM VDR Bugfixes #31

Merged
merged 3 commits into from
Aug 5, 2024
Merged

BOM VDR Bugfixes #31

merged 3 commits into from
Aug 5, 2024

Conversation

cerrussell
Copy link
Member

Changes

  • Added sort keys for VDR objects
  • Compare date only to avoid TypeError when one date is given with a timezone and the other is not.
  • Correct bom HTML report logic checking for no differences/commonalities.

@cerrussell
Fix html report bug.
13d96c5 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Add VDR sort fields.
0517dc8 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Use only date in datetime comparison
a1593d0 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell cerrussell merged commit 948534e into main Aug 5, 2024
9 checks passed
@cerrussell cerrussell deleted the fix/date-comparison-bug branch August 5, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cerrussell