Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for comparisons, expanded properties, OptionedClass superclass #39

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Bugfixes for comparisons, expanded properties, OptionedClass superclass #39

merged 7 commits into from
Oct 14, 2024

Conversation

cerrussell
Copy link
Member

Changes

  • Improved comparison logic
  • Made more class attributes private with accompanying properties
  • Moved options to a superclass and added functionality to update them (refining the combination of composition and inheritance for classes will happen for 3.x)

@cerrussell
Improvements for comparison functions.
bea59bd 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Sort results.
3b9ebda 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Filter empty at the end.
5340b46 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Add additional properties.
6dbfc09 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Use superclass for options.
fea0934 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Bump version, test python 3.13
65b5f1e 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell
Typing.
481addd 
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
@cerrussell cerrussell merged commit 411a807 into main Oct 14, 2024
12 checks passed
@cerrussell cerrussell deleted the comparison-props-enhance branch October 14, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cerrussell