Code refinement #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubnowicki
commented
May 10, 2024
jakubnowicki
commented
- Fix code style.
- Remove redundant dependencies.
- Update functions documentation
DeepanshKhurana
approved these changes
May 10, 2024
| @@ -30,7 +30,7 @@ get_access_token <- function() { | |||
| #' Simple function to make an API url | |||
| #' @param host Character. Default CONNECT_SERVER set as an envvar | |||
| #' @param endpoint Character. Default is "content" | |||
| #' @param versioned Logical. Whether to use versioned API. Default is FALSE | |||
| #' @param version Logical. Whether to use versioned API. Default is "v1" | |||
There was a problem hiding this comment.
This makes sense grammatically as well as logically. Thanks for this change!
| jsonlite[fromJSON], | ||
| dplyr[filter], | ||
| glue[glue] | ||
| magrittr[`%>%`], |
There was a problem hiding this comment.
I think Elkem had an older R version at first so we used %>% instead of |>. What do you think about changing all the pipes to the modern one and removing the magrittr dependency entirely?
There was a problem hiding this comment.
We can keep it, magrittr will be there as the dependency of dplyr, so this way we can extend the backwards compatibility with no cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.