Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improves Support + Bugfix #7

Merged
merged 13 commits into from
May 29, 2024
Merged

Fix: Improves Support + Bugfix #7

merged 13 commits into from
May 29, 2024

Conversation

DeepanshKhurana
Copy link
Member

@DeepanshKhurana DeepanshKhurana commented May 14, 2024 •
edited
Loading

Changes

  • Adds support for quarto-shiny, python-shiny along with standard shiny
  • Restricts the apps visible to a user based on the owner tag in Posit Connect.
    • There are only two tags owner (given contributor access to the app or owns the app) or viewer (given view-only access to the app)
    • If an app is shown but the user does not have owner access, the job API will fail and a 403 Forbidden error will occur. This is why I think restricting to only show the apps available to the user will work somewhat better.
    • But this is an open question and we can change the approach.
  • Fixes a scenario where no jobs are found for a particular app (prevents the app from crashing)
  • Changes from Fix: Issue with switching between apps with jobs and without #9

@DeepanshKhurana DeepanshKhurana added bug Something isn't working enhancement New feature or request labels May 14, 2024
@DeepanshKhurana DeepanshKhurana self-assigned this May 14, 2024
@DeepanshKhurana DeepanshKhurana force-pushed the fix/add-quarto-python-shiny-support branch from 19df36e to 8aa0766 Compare May 14, 2024 12:02
jakubnowicki
jakubnowicki requested changes May 24, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

app/view/mod_job_list.R Outdated Show resolved Hide resolved
app/logic/api_utils.R Outdated Show resolved Hide resolved
app/view/mod_job_list.R Outdated Show resolved Hide resolved
jakubnowicki
jakubnowicki requested changes May 28, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

app/logic/api_utils.R Outdated Show resolved Hide resolved
app/logic/api_utils.R Show resolved Hide resolved
tests/testthat/test-job_list_utils.R Outdated Show resolved Hide resolved
tests/testthat/test-job_list_utils.R Outdated Show resolved Hide resolved
jakubnowicki
jakubnowicki approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please resolve my comment and you can merge.

@DeepanshKhurana DeepanshKhurana merged commit adbadfc into main May 29, 2024
1 check passed
@DeepanshKhurana DeepanshKhurana deleted the fix/add-quarto-python-shiny-support branch May 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees

@DeepanshKhurana DeepanshKhurana

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepanshKhurana @jakubnowicki