Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue with switching between apps with jobs and without #9

Conversation

DeepanshKhurana
Copy link
Member

@DeepanshKhurana DeepanshKhurana commented May 14, 2024

Have you read the Contributing Guidelines?

Closes #8

Description

  • We now check for the job_list() to have valid length before proceeding, therefore fixing the reactivity.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@DeepanshKhurana DeepanshKhurana added the bug Something isn't working label May 14, 2024
@DeepanshKhurana DeepanshKhurana self-assigned this May 14, 2024
@DeepanshKhurana DeepanshKhurana merged commit 903ca2f into fix/add-quarto-python-shiny-support May 27, 2024
1 check passed
@DeepanshKhurana DeepanshKhurana deleted the fix/jobless-apps-switch-breaking-issue branch May 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Changing the app after viewing logs for another crashes the whole application
2 participants