Merge pull request #109 from Appsilon/tomek.abstract_class_no_init

No initialization of abstract class
Appsilon · Apr 28, 2023 · c1ac1f6 · c1ac1f6
2 parents 1fbfdb1 + 8d261cb
commit c1ac1f6
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 52 deletions.
diff --git a/R/data-storage-log-file.R b/R/data-storage-log-file.R
@@ -36,7 +36,6 @@ DataStorageLogFile <- R6::R6Class( # nolint object_name_linter
     #' @param log_file_path string with path to JSON log file user actions
 
     initialize = function(log_file_path) {
-      super$initialize()
       logger::log_debug(
         "path to file: {log_file_path}",
         namespace = "shiny.telemetry"

diff --git a/R/data-storage-mariadb.R b/R/data-storage-mariadb.R
@@ -47,7 +47,6 @@ DataStorageMariaDB <- R6::R6Class( # nolint object_name_linter
       port = 3306,
       dbname = "shiny_telemetry"
     ) {
-      super$initialize()
       checkmate::assert_string(password)
       checkmate::assert_string(username)
       checkmate::assert_string(hostname)

diff --git a/R/data-storage-plumber.R b/R/data-storage-plumber.R
@@ -68,7 +68,6 @@ DataStoragePlumber <- R6::R6Class( # nolint object_name_linter
       secret = NULL,
       authorization = NULL
     ) {
-      super$initialize()
 
       private$hostname <- hostname
       private$port <- port

diff --git a/R/data-storage-postgresql.R b/R/data-storage-postgresql.R
@@ -46,7 +46,6 @@ DataStoragePostgreSQL <- R6::R6Class( # nolint object_name_linter
       port = 5432,
       dbname = "shiny_telemetry"
     ) {
-      super$initialize()
       checkmate::assert_string(password)
       checkmate::assert_string(username)
       checkmate::assert_string(hostname)

diff --git a/R/data-storage-sql-family.R b/R/data-storage-sql-family.R
@@ -9,14 +9,6 @@ DataStorageSQLFamily <- R6::R6Class( # nolint object_name_linter
   #
   # Public
   public = list(
-
-    #' @description
-    #' Initialize the data storage class
-
-    initialize = function() {
-      super$initialize()
-    }
-
   ),
   #
   # Private

diff --git a/R/data-storage-sqlite.R b/R/data-storage-sqlite.R
@@ -38,7 +38,6 @@ DataStorageSQLite <- R6::R6Class( # nolint object_name_linter
     initialize = function(
       db_path = "user_stats.sqlite"
     ) {
-      super$initialize()
 
       logger::log_debug("path to db: {db_path}", namespace = "shiny.telemetry")
       private$connect(db_path)

diff --git a/R/data-storage.R b/R/data-storage.R
@@ -12,7 +12,7 @@ DataStorage <- R6::R6Class( # nolint object_name_linter
     #' @description initialize data storage object common with all providers
 
     initialize = function() {
-
+      stop(paste(class(self)[1], "is an abstract class that can't be initialized."))
     },
 
     #' @description Insert new data

diff --git a/tests/testthat/test-data_storage.R b/tests/testthat/test-data_storage.R