Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use uv instead of poetry for packages management #54

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Conversation

pstorozenko
Copy link
Collaborator

@pstorozenko pstorozenko commented Sep 18, 2024

Tapyr release 0.2

  • Default python upgrade to 3.12
  • poetry changed to uv
  • .gitignore cleanup
  • versions bump
  • PyShiny -> Shiny for Python rebranding
  • Introduce usage of Shiny Testing API instead of raw Playwright
  • Change favicon to tapyr
  • Extend and improve basic startup tests

Copy link
Member

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a couple of minor comments.

I was able to run the app fine, and the manual deployment went smoothly.

Idea for another PR is to include a module example. Even in shiny docs it's not very easy (i.e. takes >5s) to find how to create a module with separate ui and server.

.gitignore Outdated Show resolved Hide resolved
uv.lock Outdated Show resolved Hide resolved
tests/playwirght/conftest.py Show resolved Hide resolved
tapyr_template/view/root/server.py Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Gotfrid
Copy link
Member

Gotfrid commented Oct 18, 2024

Another minor thing that I just remembered: it might be good to install rsconnect-python in the devcontainer, or at least mention that it should be installed by the user. why i mention it, is, as you see, pip package name is different from the command.

@f-meister
Copy link

Another minor thing that I just remembered: it might be good to install rsconnect-python in the devcontainer, or at least mention that it should be installed by the user. why i mention it, is, as you see, pip package name is different from the command.

I second this. It's not clear in the documentation that you need to install rsconnect separately. Also suggest that they use uv in this case—if I hadn't already known about uv, I would not know that I had to do something like:

uv pip install rsconnect

to install and just do the usual pip install and maybe defeat the whole purpose of having uv ?

Copy link

@f-meister f-meister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM. Just some documentation stuff from me to ensure new users get through the initial process smoothly 😄

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@pstorozenko pstorozenko marked this pull request as ready for review October 18, 2024 15:37
@pstorozenko pstorozenko merged commit ae10e11 into main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants