Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 7 - Minor corrections / confusion / formatting issues (Pages 251, 257, 272) #40

Open
scouttyg opened this issue Oct 5, 2020 · 0 comments

Comments

@scouttyg
Copy link

scouttyg commented Oct 5, 2020

  1. On page 251, we're told to create a RPGCameraManager script, but most times we're also told where to put it. For the case of this Script, it probably makes sense to put this in Assets -> Scripts -> Managers.
  2. On page 257, under The Enemy Class, the last line in the section says:

[...] using a regular float variable to track hit-points instead.
The code formatting either shouldn't be present, or should end possibly after float variable.

  1. On page 272, under OnCollisionEnter2D, it later makes sense that we want both this method and OnCollisionExit2D to be part of our Enemy Class, but since the section starts off with explaining what the method is, it sounded like it was at first just mentioning what it was, but then immediately gave us a method. Comment // 2 seems to help clarify this is in Enemy, but it still caught me a bit off guard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant