From 70ec7616df12e01cc326b8bf35f41ebabf8f16f5 Mon Sep 17 00:00:00 2001 From: shinkuan <35415788+shinkuan@users.noreply.github.com> Date: Sun, 21 Jul 2024 23:27:39 +0800 Subject: [PATCH 1/3] Fix: `user_data_dir` saved data to wrong location (#278) * Fix: `user_data_dir` saved data to wrong location https://github.com/Apricot-S/majsoulrpa/issues/277 * Fix: When `user_data_dir` is relative Path(), it saved data to wrong location * Remove extra spaces and use resolve() --------- Co-authored-by: shinkuan --- src/majsoulrpa/_impl/browser.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/majsoulrpa/_impl/browser.py b/src/majsoulrpa/_impl/browser.py index 089a220..54f62ec 100644 --- a/src/majsoulrpa/_impl/browser.py +++ b/src/majsoulrpa/_impl/browser.py @@ -188,6 +188,9 @@ def __init__( self._browser = None if user_data_dir: + if isinstance(user_data_dir, str): + user_data_dir = Path(user_data_dir) + user_data_dir = user_data_dir.resolve() self._context = self._context_manager.start().chromium.launch_persistent_context( # noqa: E501 user_data_dir, args=options, From ad6fee62ef34843c951ec808780684f446896e4f Mon Sep 17 00:00:00 2001 From: "Apricot S." <152096077+Apricot-S@users.noreply.github.com> Date: Mon, 22 Jul 2024 02:33:27 +0900 Subject: [PATCH 2/3] fix: Always resolve `user_data_dir` to an absolute path (#279) --- src/majsoulrpa/remote_browser/_remote_browser.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/majsoulrpa/remote_browser/_remote_browser.py b/src/majsoulrpa/remote_browser/_remote_browser.py index 5e0d8f6..3874bf1 100644 --- a/src/majsoulrpa/remote_browser/_remote_browser.py +++ b/src/majsoulrpa/remote_browser/_remote_browser.py @@ -231,6 +231,10 @@ def launch_remote_browser( mute_audio_off = None if headless else ["--mute-audio"] if user_data_dir: + if isinstance(user_data_dir, str): + user_data_dir = Path(user_data_dir) + user_data_dir = user_data_dir.resolve() + with ( sync_playwright() as playwright, playwright.chromium.launch_persistent_context( From 4d4b87ef7eea7cb2091f416f092805db6eab2f71 Mon Sep 17 00:00:00 2001 From: Apricot-S Date: Mon, 22 Jul 2024 02:56:12 +0900 Subject: [PATCH 3/3] chore: bump up version to v0.0.4 --- pyproject.toml | 2 +- src/majsoulrpa/_version.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 9c7b382..9b16d45 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "majsoulrpa" -version = "0.0.3" +version = "0.0.4" description = "A Robotic Process Automation (RPA) framework for Mahjong Soul (雀魂)" authors = [ { name = "Apricot S." } diff --git a/src/majsoulrpa/_version.py b/src/majsoulrpa/_version.py index 5d9050f..95a29dc 100644 --- a/src/majsoulrpa/_version.py +++ b/src/majsoulrpa/_version.py @@ -1 +1 @@ -__version__ = "0.0.3" +__version__ = "0.0.4"