ref - No need to have the repopulate variable

--- Type: ref Breaking: False Doc Required: False Part: 1/1
Aptivi · Oct 16, 2023 · 6193bc9 · 6193bc9
1 parent f01ded2
commit 6193bc9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/BassBoom.Cli/CliBase/Player.cs b/BassBoom.Cli/CliBase/Player.cs
@@ -52,7 +52,6 @@ internal static class Player
         internal static int position = 0;
         internal static bool advance = false;
         internal static bool populate = true;
-        internal static bool regen = true;
         internal static bool paused = false;
         internal static string cachedLyric = "";
         internal static readonly List<string> musicFiles = new();
@@ -114,13 +113,6 @@ public static void PlayerLoop()
                         TextWriterWhereColor.WriteWhere(ConsoleExtensions.GetClearLineToRightSequence(), 0, ConsoleWrappers.ActionWindowHeight() - 10);
                         cachedLyric = "";
 
-                        // Regenerate as necessary
-                        if (regen)
-                        {
-                            regen = false;
-                            playerThread = new(HandlePlay);
-                        }
-
                         // Wait for any keystroke
                         if (ConsoleWrappers.ActionKeyAvailable())
                         {
@@ -172,16 +164,19 @@ private static void HandleKeypressIdleMode(ConsoleKeyInfo keystroke)
                     PlayerControls.LowerVolume();
                     break;
                 case ConsoleKey.Spacebar:
+                    playerThread = new(HandlePlay);
                     PlayerControls.Play();
                     break;
                 case ConsoleKey.B:
                     PlayerControls.SeekBeginning();
                     PlayerControls.PreviousSong();
+                    playerThread = new(HandlePlay);
                     PlayerControls.Play();
                     break;
                 case ConsoleKey.N:
                     PlayerControls.SeekBeginning();
                     PlayerControls.NextSong();
+                    playerThread = new(HandlePlay);
                     PlayerControls.Play();
                     break;
                 case ConsoleKey.H:
@@ -276,7 +271,6 @@ private static void HandlePlay()
                 lyricInstance = null;
                 rerender = true;
             }
-            regen = true;
         }
 
         private static void HandleDraw()

diff --git a/BassBoom.Cli/CliBase/PlayerControls.cs b/BassBoom.Cli/CliBase/PlayerControls.cs
@@ -88,15 +88,13 @@ internal static void Play()
         internal static void Pause()
         {
             Player.advance = false;
-            Player.regen = true;
             Player.paused = true;
             PlaybackTools.Pause();
         }
 
         internal static void Stop(bool resetCurrentSong = true)
         {
             Player.advance = false;
-            Player.regen = true;
             Player.paused = false;
             if (resetCurrentSong)
                 Player.currentSong = 1;