From e76c5841ef063a7009d95cc49d40a66e7d2cad07 Mon Sep 17 00:00:00 2001 From: Aptivi CEO Date: Thu, 22 Aug 2024 18:08:28 +0300 Subject: [PATCH] imp - Don't invoke msbuild directly --- For build scripts, invoking dotnet with msbuild is taking us back to the days where we would build "msbuild" for Mono in a PPA explicitly using mono-msbuild in April 2021. We've changed the dotnet command to be more current as the "msbuild" approach is so 2021. --- Type: imp Breaking: False Doc Required: False Backport Required: False Part: 1/1 --- tools/build.cmd | 4 ++-- tools/build.sh | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/build.cmd b/tools/build.cmd index 272d239..2c30208 100644 --- a/tools/build.cmd +++ b/tools/build.cmd @@ -23,14 +23,14 @@ if "%releaseconfig%" == "" set releaseconfig=Release :download echo Downloading packages... -"%ProgramFiles%\dotnet\dotnet.exe" msbuild "..\BassBoom.sln" -t:restore -p:Configuration=%releaseconfig% +"%ProgramFiles%\dotnet\dotnet.exe" restore "..\BassBoom.sln" -t:restore --configuration %releaseconfig% if %errorlevel% == 0 goto :build echo There was an error trying to download packages (%errorlevel%). goto :finished :build echo Building BassBoom... -"%ProgramFiles%\dotnet\dotnet.exe" msbuild "..\BassBoom.sln" -p:Configuration=%releaseconfig% +"%ProgramFiles%\dotnet\dotnet.exe" build "..\BassBoom.sln" --configuration %releaseconfig% if %errorlevel% == 0 goto :success echo There was an error trying to build (%errorlevel%). goto :finished diff --git a/tools/build.sh b/tools/build.sh index 114270d..ed0fa72 100755 --- a/tools/build.sh +++ b/tools/build.sh @@ -32,15 +32,15 @@ fi # Download packages echo Downloading packages... -"$dotnetpath" msbuild "../BassBoom.sln" -t:restore -p:Configuration=$releaseconf +"$dotnetpath" restore "../BassBoom.sln" --configuration $releaseconf if [ ! $? == 0 ]; then echo Download failed. exit 1 fi -# Build KS -echo Building KS... -"$dotnetpath" msbuild "../BassBoom.sln" -p:Configuration=$releaseconf +# Build +echo Building BassBoom... +"$dotnetpath" build "../BassBoom.sln" --configuration $releaseconf if [ ! $? == 0 ]; then echo Build failed. exit 1