Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: More control over progressive symbols #3961

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Sep 19, 2024

Add "Progressive Shapers", "Progressive Squares" and "Progressive Line-Counting Symbols".

Also adds more configurability:

  1. Add "Progressive Symbols" OptionSet where you can choose which chains you actually want.
  2. Make it configurable via a hidden option whether "Colored Dots" and "Sound Dots" are part of "Progressive Dots".
  3. Make it configurable via a hidden option whether the second stage items should act independently if not progressive, i.e. whether "Full Dots" should unlock a Full Dots panel even if you don't have "Dots".

The current behavior can be expressed through these new options, and that's how the defaults for them were chosen.

Also removes the unused "Invisible Dots" item.

Also removes unused symbols from WitnessLogicExpert.txt

To achieve this, the progressive items code needed to be adjusted to be per-slot, which makes this PR somewhat big.

Drafted until 0.5.1 releases & the dust settles on it, at which point I will release a beta client that is compatible with these options.

Waiting on: #3999, otherwise this breaks item links.

@NewSoupVi NewSoupVi marked this pull request as draft September 19, 2024 00:41
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 19, 2024
@NewSoupVi NewSoupVi changed the title More control over progressive symbols! The Witness: More control over progressive symbols Sep 19, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review help:

Every change in the Logic.txt files should fall under these categories.

  1. Removing "Dots" when "Full Dots" is already there
  2. Removing "Stars" when "Stars + Same Colored Symbol" is already there
  3. Removing Symmetry off of the Laser set specifically

This was done with regex replacement and probably does not need to be reviewed too thoroughly

@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 19, 2024
@NewSoupVi
Copy link
Member Author

Unit tests are written. I now need to test that the client handles it all correctly, and then release a new beta version of it.

@NewSoupVi
Copy link
Member Author

This is now waiting on the release of 0.5.1, because I realized I don't want to mess with the beta client any further, since I might have to release it soon

@NewSoupVi NewSoupVi added the waiting-on: other Issue/PR is waiting for something else, like another PR. label Sep 19, 2024
@Exempt-Medic
Copy link
Collaborator

Exempt-Medic commented Sep 25, 2024

This fails with itemlinks (just putting the comment here so it can be here too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: other Issue/PR is waiting for something else, like another PR. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants