-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Witness: More control over progressive symbols #3961
Draft
NewSoupVi
wants to merge
47
commits into
ArchipelagoMW:main
Choose a base branch
from
NewSoupVi:progressive_symbol_options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,130
−557
Draft
Changes from 5 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
d9027f3
More control over progressive symbols!
NewSoupVi 065274d
Cleanup crew
NewSoupVi d328213
lol
NewSoupVi c8aa350
Make it configurable how second stage items act on their own
NewSoupVi 63861a0
only let independent symbols work if they're not progressive
NewSoupVi 5c92fb0
revert defaults
NewSoupVi 1b8a856
Better description
NewSoupVi 4ded65a
comment for reviewers
NewSoupVi 84a59a6
A complicated docstring for a complicated function
NewSoupVi 827f5d3
More accurate
NewSoupVi 1fa5ec0
This probably works more generically
NewSoupVi 31e0f48
Actually, this would cause other issues anyway, so no need to make th…
NewSoupVi 3d79c84
:/
NewSoupVi f3003b1
oops
NewSoupVi 67d4fd0
Change the system to use collect/remove override so that plando and s…
NewSoupVi da74ecc
Vi stop doing that thing challenge
NewSoupVi 4c24963
Make SecondStateSymbolsActIndependently an OptionSet
NewSoupVi b3cb5e9
jank
NewSoupVi d4ddcb6
oop
NewSoupVi ba29b31
this is why we make unit tests I guess
NewSoupVi bb98ac8
More unit tests
NewSoupVi 4ac815b
More unit tests
NewSoupVi 49b8f24
Add note about the absence of Rotated Shapers from the independent sy…
NewSoupVi cfee7ff
More verbose description
NewSoupVi c4721ab
More verbose description
NewSoupVi 403788a
slight reword
NewSoupVi 83860e0
Ruff ruff :3 I am a good puppy <3
NewSoupVi 2dac460
Remove invis dots
NewSoupVi a7507e7
oops
NewSoupVi 64b39f3
Remove some unused symbols
NewSoupVi bfd2b58
display name
NewSoupVi 5e3a556
linecounting -> discard
NewSoupVi 035b1a0
Make all progressive chains always work
NewSoupVi 03492d8
Unfortunately, this optimisation is now unsafe with plando :(
NewSoupVi 01dfb36
oops
NewSoupVi 4c37d22
This is now a possible optimisation
NewSoupVi 4e1ba53
optimise optimise optimise
NewSoupVi a93a152
optimise optimise optimise
NewSoupVi 0a0cc13
fix
NewSoupVi dde5638
ruff
NewSoupVi a19d36f
oh
NewSoupVi b7bb723
fixed frfr
NewSoupVi 6b8ce5c
mypy
NewSoupVi d6942e2
Clean up the tests a bit
NewSoupVi afedaab
oop
NewSoupVi d622f2c
I actually like this better now, so I'm doing it as default
NewSoupVi af29c2a
Merge branch 'main' into progressive_symbol_options
NewSoupVi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review help:
Every change in the Logic.txt files should fall under these categories.
This was done with regex replacement and probably does not need to be reviewed too thoroughly