Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADX: enable upstream options #3962

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

threeandthreee
Copy link
Contributor

@threeandthreee threeandthreee commented Sep 19, 2024

What is this fixing or adding?

There are some upstream settings that just needed options entries. This should come after the logic updates (#3963) because of hard mode, not sure if current logic has all the correct handling of it, and not much point in checking.

Hard Mode

  • [None]
  • [Oracle] Less iframes and health from drops. Bombs damage yourself. Water damages you without flippers. No piece of power or acorn.
  • [Hero] Switch version hero mode, double damage, no heart/fairy drops.
  • [One hit KO] You die on a single hit, always.

Quickswap

Adds that the select buttons swaps with either A or B. The item is swapped with the top inventory slot. The map is not available when quickswap is enabled.

Text Mode

  • [Normal]
  • [Fast] Makes text appear twice as fast
  • [No-Text] Removes all text from the game
    This one has been defaulted to Fast, as upstream does. Also opted to make this a hidden option but will be getting community feedback on that. No-text might be problematic, will need to test directly and possibly disable.

Low HP Beep

Slows or disables the low health beeping sound.

No Flash

Remove the flashing light effects from Mamu, shopkeeper and MadBatter. Useful for capture cards and people that are sensitive for these things.

This has been defaulted on (matching upstream) and hidden, community feedback pending.

How was this tested?

Tested that the settings work and don't break anything, but not every arrangement. No-text needs to be tested specifically.

@Exempt-Medic
Copy link
Collaborator

What's the reason for the visibility values?

@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 19, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: other Issue/PR is waiting for something else, like another PR. label Sep 19, 2024
@threeandthreee
Copy link
Contributor Author

Seemed like unnecessary settings. I'd probably just make them normal at this point but we've already got our feedback stuff set up so just going to wait for community feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: other Issue/PR is waiting for something else, like another PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants