LADX: stealing logic option #3965
Open
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
threeandthreee
changed the title
ScipioWright
added
the
is: enhancement
Exempt-Medic
added
the
waiting-on: other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds an option for whether or not stealing from the shop is in logic.
This should come after logic updates (#3963)
From this poll: https://discord.com/channels/731205301247803413/1090819435893362768/1284603279480983613
Modified and enabled an unused upstream setting for this. Upstream, stealing is always out of logic and the setting makes stealing impossible by keeping the shopkeeper from turning around. We opted instead to do the opposite and change logic without touching the shopkeeper, since people often play Archipelago with unknown settings and stealing mysteriously not working would likely be confusing.
How was this tested?
Generated, checked spoilers to verify logic