Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yacht Dice: Textual fixes and changes (Docs / yaml description) #3967

Open
wants to merge 133 commits into
base: main
Choose a base branch
from

Conversation

spinerak
Copy link
Contributor

What is this fixing or adding?

I've changed several textual... texts.
Most importantly, I've changed the setup guide (there was a broken link in there too; ../player-options).
I've made it much simpler, not explaining the entire AP workings.

How was this tested?

I've tried and tested it via webhost.

spinerak and others added 24 commits June 15, 2024 01:03
2.0.5 is the apworld I released on github to be tested
I never separately released 2.0.4.
- changed names in YachtWeights so we don't need to translate them in Rules anymore
- we now remember which categories are present in the game, and also put this in slotdata. This we do because only one of two categories is present in a game. If for some reason both are present (plando/getitem/startinventory), we now know which category to ignore
-
- Change logic, generation is now even faster (0.6s per default yaml).
- Made the option 'minimize_extra_items' do a lot more, hopefully this makes the impact of Yacht Dice a little bit less, if you want that. Here's what is also does now:
 - you start with 2 dice and 2 rolls
 - there will be less locations/items at the start of you game
On the installation page, link to the latest release, instead of the page with all releases
-change apworld version
-Removed the extra roll (this was not intended)
-change extra_points_added to a mutable list to that it actually does something
-removed variables multipliers_added and items_added
-Rules, don't order by quantity, just by mean_score
-Changed the weights in general to make it faster
Yacht Dice local to AP+changes to main
Too many step score multipliers lead to gen fails too, probably because you need many categories for them to actually help a lot. So it's hard to use them at the start of the game.
add archipelago into yacht dice fork
MERGE TO YACHT DICE LOCAL
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 19, 2024
@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 19, 2024
@spinerak
Copy link
Contributor Author

spinerak commented Sep 19, 2024

ah damn I messed up and added other stuff to this PR, hold....

@spinerak
Copy link
Contributor Author

I reverted it, ok should be good again......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants