-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: purge py3.8 and py3.9 #3973
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting
Co-authored-by: Remy Jette <remy@remyjette.com>
Could you elaborate on what Stardew does / needs to do? |
There's at least
Also maybe these:
|
@Jouramie Just pinging you to keep you in the loop, you're generally much more aware than me of how these things work |
Yeah there are a couple of things to clean up in stardew, nothing big. |
What is this fixing or adding?
Fixes py 3.8 and py 3.9 by yeeting them.
Fixes Windows 7 support, by no longer supporting it.
I touched HK because I wrote that code, I saw stardew has 3.8 stuff too, didn't touch that. There's a couple more 3.8 marked todos, I left some of them alone as they either go beyond deprecation (redesign/changes) or had a question mark. Once we know what to do with those, I suppose those changes could target this branch and we can accumulate it.
How was this tested?
A bit of generate and webhost, but it's probably too early to broadly test at this time.
I also don't currently know why this fails: