-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Make an actual LogicMixin spec & explanation #3975
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but also you told me about it in the first place so
docs/world api.md
Outdated
Only use LogicMixin if necessary. There are often other ways to achieve what it does, like making clever use of | ||
`state.prog_items`, or using event items, pseudo-regions etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only use LogicMixin if necessary. There are often other ways to achieve what it does, like making clever use of | |
`state.prog_items`, or using event items, pseudo-regions etc. | |
Only use LogicMixin if necessary. There are often other ways to achieve what it does, like making clever use of | |
`state.prog_items`, using event items, pseudo-regions, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I guess it's fine, it does read better.
The reason I wrote it this way is because in my mind, these are two different "groups" of concepts
- Accessing state data directly (
state.prog_items
, theoretically also stuff likestate.reachable_regions
orstate.blocked_connections
) - Using objects from the "normal" classes to express extra logic ("Pseudo" Regions, (Event) Items / Locations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very minimum you need to put the , before etc., or instead of etc. you could write out "or other things" or something like that, I think that would get your way of saying it across better.
Co-authored-by: Scipio Wright <scipiowright@gmail.com>
No description provided.