-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minecraft: Set "Two by Two" and "A Complete Catalogue" to "unreasonable" exclusion group #3977
base: main
Are you sure you want to change the base?
Conversation
Set "Two by Two" and "A Complete Catalogue" to "unreasonable" exclusion group
Reason: Played this in a competitive game, and Two by Two was BK-ing a peer on my team. Couldn't goal my game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates fine and the wished for changes are being considered. The locations are now part of the unreasonable subset.
I also think this change is a good one.
However, the YAML also needs to be changed as "include_unreasonable_advancements" specifies all included achievements.
I PR'd a fix: ArchooD2#1
…reasonable achievements in the YAML
Adds the newly classified unreasonable achievements to the YAML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Both code and docs wise.
Why exactly is 'A Complete Catalogue' being classified as "Unreasonable" here? There's no explanation given in the PR message or comments. I also disagree with 'Two by Two' being classified as "Unreasonable" - I don't think it's as difficult as 'Monsters Hunted', for example - but at the moment its client integration has an issue that can make it impossible in some seeds, so this seems fine to me as a band-aid fix. I don't believe that it should remain that way once the client is fixed, though. |
I'm also against these changes. This sounds like more of a use for the generic feature of excluded locations. |
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
This changes the advancement groups of:
"Two by Two" and "A Complete Catalogue"
from "hard" to "unreasonable" exclusion group
How was this tested?
Running a 63 player all-minecraft with a yaml that enables 'hard' but disables 'unreasonable', and verified that they were all junk items.
If this makes graphical changes, please attach screenshots.
N/A