Core: Import TypeGuard from native typing instead of typing_extentions
#3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because #3973 (comment) |
Jouramie
changed the title
TypeGuard from native typing instead of typing_extentionsTypeGuard from native typing instead of typing_extentions
NewSoupVi
added
is: maintenance
Berserker66
merged commit 85c94ea
into
ArchipelagoMW:core_min_py_3_10
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Import
TypeGuardfrom native typing instead of typing_extentions. I'm not removing typing_extentions from therequirements.txttho, because it's used for other stuff only supported since 3.11 and 3.12How was this tested?
Ran the unit tests
If this makes graphical changes, please attach screenshots.
N/A