Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of slot data for trackers in World API doc #3986

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

massimilianodelliubaldini

What is this fixing or adding?

Adding some language to clarify that using slot data for trackers to keep tabs on your game, your options, etc is acceptable.

How was this tested?

Proofread myself, found typo already.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 22, 2024
@NewSoupVi
Copy link
Member

I'm ok with this but would like to have a native speaker have a look at this, to me it feels like it adds more words than it needs to

@massimilianodelliubaldini
Copy link
Author

Fair enough, I tend on the wordy side anyway, guilty as charged.

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few recommendations, none of which I consider to be necessary to be merged

docs/world api.md Outdated Show resolved Hide resolved
docs/world api.md Outdated Show resolved Hide resolved
docs/world api.md Outdated Show resolved Hide resolved
Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants