Core: skip creating item linked locations for non prog items #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
|
I think this is kind of awesome if it works but it seems scary lol |
NewSoupVi
added
the
is: bug/fix
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
|
Just to document this here: It does remove the locations from spoiler log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
removes any headache from core trying to do accessibility checks on unreachable items (because they are logically locked behind the Group's non-prog copies)
How was this tested?
generated a single player world with an item link on filler, hosted locally, connected, hinted the filler item, sent the location through postman, saw the hints, recievedItem go through without issue, also inspected the spoiler log and the link was still fully described in the spoiler
If this makes graphical changes, please attach screenshots.